lang/es/left-menu.php (1)

27-27: ⚡ Quick win

English placeholder should be translated to Spanish.

The shopSizes key currently uses the English text "Size Catalogue" instead of a Spanish translation (e.g., "Catálogo de Tamaños"). While English placeholders are acceptable for the initial rollout, consider translating to Spanish in a follow-up.

lang/es/webshop.php (1)

36-38: ⚡ Quick win

Complete Spanish translations for remaining English placeholders.

Several keys have Spanish translations (lines 81, 84-85), but many remain in English (basketList additions, buyMeDialog, sizeCatalogue, printSizePricesInput, pixelSizePricesInput, shippingAddress sections). Consider completing the Spanish translations in a follow-up for consistency.

Also applies to: 235-279

lang/fa/left-menu.php (1)

28-28: ⚡ Quick win

English placeholder should be translated to Persian.

The shopSizes key uses English text instead of Persian (Farsi) translation. Consider translating to Persian in a follow-up for consistency with the locale.

lang/fa/webshop.php (1)

36-38: ⚡ Quick win

Complete Persian translations for remaining English placeholders.

Several keys have Persian translations (lines 81, 84-85), but many remain in English (basketList additions, buyMeDialog, sizeCatalogue, printSizePricesInput, pixelSizePricesInput, shippingAddress sections). Consider completing the Persian translations in a follow-up for consistency.

Also applies to: 235-279

lang/fr/left-menu.php (1)

28-28: ⚡ Quick win

English placeholder should be translated to French.

The shopSizes key uses English text instead of a French translation (e.g., "Catalogue de Tailles"). Consider translating to French in a follow-up for consistency with the locale.

lang/fr/webshop.php (1)

36-38: ⚡ Quick win

Complete French translations for remaining English placeholders.

Several keys have French translations (lines 81, 84-85), but many remain in English (basketList additions, buyMeDialog, sizeCatalogue, printSizePricesInput, pixelSizePricesInput, shippingAddress sections). Consider completing the French translations in a follow-up for consistency.

Also applies to: 235-279

lang/hu/left-menu.php (1)

28-28: ⚡ Quick win

English placeholder should be translated to Hungarian.

The shopSizes key uses English text instead of a Hungarian translation (e.g., "Méret Katalógus"). Consider translating to Hungarian in a follow-up for consistency with the locale.

lang/no/webshop.php (1)

235-279: ⚡ Quick win

Complete Norwegian translations for new webshop sections.

The new translation groups (buyMeDialog, sizeCatalogue, printSizePricesInput, pixelSizePricesInput, shippingAddress) contain English placeholder strings rather than Norwegian translations. While lines 81, 84-85 correctly provide Norwegian text, these larger sections remain untranslated.

For a Norwegian locale file, users expect Norwegian strings throughout.

lang/pl/left-menu.php (1)

28-28: ⚡ Quick win

Translate 'Size Catalogue' to Polish.

The value for shopSizes is in English. Polish locale files should provide Polish translations.

lang/pl/webshop.php (1)

235-279: ⚡ Quick win

Complete Polish translations for new webshop sections.

The new translation groups (buyMeDialog, sizeCatalogue, printSizePricesInput, pixelSizePricesInput, shippingAddress) contain English placeholder strings. Lines 81, 84-85 correctly provide Polish text, but these sections remain untranslated.

lang/pt/left-menu.php (1)

28-28: ⚡ Quick win

Translate 'Size Catalogue' to Portuguese.

The value for shopSizes is in English. Portuguese locale files should provide Portuguese translations.

lang/pt/webshop.php (1)

235-279: ⚡ Quick win

Complete Portuguese translations for new webshop sections.

The new translation groups (buyMeDialog, sizeCatalogue, printSizePricesInput, pixelSizePricesInput, shippingAddress) contain English placeholder strings. Lines 81, 84-85 correctly provide Portuguese text, but these sections remain untranslated.

lang/ru/left-menu.php (1)

28-28: ⚡ Quick win

Translate 'Size Catalogue' to Russian.

The value for shopSizes is in English. Russian locale files should provide Russian translations.

lang/ru/webshop.php (1)

235-279: ⚡ Quick win

Complete Russian translations for new webshop sections.

The new translation groups (buyMeDialog, sizeCatalogue, printSizePricesInput, pixelSizePricesInput, shippingAddress) contain English placeholder strings. Lines 81, 84-85 correctly provide Russian text, but these sections remain untranslated.

lang/sk/left-menu.php (1)

28-28: ⚡ Quick win

Translate 'Size Catalogue' to Slovak.

The value for shopSizes is in English. Slovak locale files should provide Slovak translations.

app/Http/Controllers/Admin/PrintSizeManagementController.php (1)

31-31: ⚡ Quick win

Remove redundant ->all() call.

PrintSize::all() already returns a Collection. The chained ->all() converts it to a plain array, but then PrintSizeResource::collect() expects a collection or array. The double ->all() is redundant; use PrintSize::all() directly.

♻️ Proposed fix

-		return PrintSizeResource::collect(PrintSize::all()->all());
+		return PrintSizeResource::collect(PrintSize::all());

app/Http/Controllers/Shop/CheckoutController.php (1)

70-88: ⚖️ Poor tradeoff

Consider refactoring repetitive null checks.

The six shipping address fields follow an identical pattern. While explicit and clear, this could be refactored to reduce duplication.

♻️ Optional refactor to reduce duplication

-		// Store shipping address if provided
-		if ($request->shipping_street_name !== null) {
-			$order->shipping_street_name = $request->shipping_street_name;
-		}
-		if ($request->shipping_street_number !== null) {
-			$order->shipping_street_number = $request->shipping_street_number;
-		}
-		if ($request->shipping_additional_info !== null) {
-			$order->shipping_additional_info = $request->shipping_additional_info;
-		}
-		if ($request->shipping_city !== null) {
-			$order->shipping_city = $request->shipping_city;
-		}
-		if ($request->shipping_post_code !== null) {
-			$order->shipping_post_code = $request->shipping_post_code;
-		}
-		if ($request->shipping_country !== null) {
-			$order->shipping_country = $request->shipping_country;
-		}
+		// Store shipping address if provided
+		foreach (['shipping_street_name', 'shipping_street_number', 'shipping_additional_info', 
+		          'shipping_city', 'shipping_post_code', 'shipping_country'] as $field) {
+			if ($request->$field !== null) {
+				$order->$field = $request->$field;
+			}
+		}

database/migrations/2026_05_31_000006_extend_orders_for_shipping.php (1)

20-25: ⚖️ Poor tradeoff

Consider specifying explicit lengths for shipping address fields.

While Laravel's default varchar(255) works, explicit lengths would better express intent:

• shipping_post_code: typically 10-20 chars max
• shipping_country: could use 2 chars for ISO codes or 100 for full names
• Street/city fields: 255 is reasonable

♻️ Optional refinement with explicit lengths

 		Schema::table('orders', function (Blueprint $table) {
-			$table->string('shipping_street_name')->nullable()->after('comment');
-			$table->string('shipping_street_number')->nullable()->after('shipping_street_name');
+			$table->string('shipping_street_name', 255)->nullable()->after('comment');
+			$table->string('shipping_street_number', 50)->nullable()->after('shipping_street_name');
 			$table->string('shipping_additional_info')->nullable()->after('shipping_street_number');
-			$table->string('shipping_city')->nullable()->after('shipping_additional_info');
-			$table->string('shipping_post_code')->nullable()->after('shipping_city');
-			$table->string('shipping_country')->nullable()->after('shipping_post_code');
+			$table->string('shipping_city', 255)->nullable()->after('shipping_additional_info');
+			$table->string('shipping_post_code', 20)->nullable()->after('shipping_city');
+			$table->string('shipping_country', 100)->nullable()->after('shipping_post_code');
 		});

resources/js/components/forms/shop-management/PixelSizePricesInput.vue (2)

43-48: ⚡ Quick win

Consolidate Vue imports to eliminate duplication.

The watch function is imported separately on line 48, but it should be imported alongside onMounted and ref on line 43.

♻️ Consolidate imports

-import { onMounted, ref } from "vue";
+import { onMounted, ref, watch } from "vue";
 import InputCurrency from "`@/components/forms/basic/InputCurrency.vue`";
 import ShopManagementService from "`@/services/shop-management-service`";
 import { useShopManagementStore } from "`@/stores/ShopManagement`";
 import { storeToRefs } from "pinia";
-import { watch } from "vue";

---

65-65: ⚡ Quick win

Compute default item dynamically to avoid stale pricing.

The _defaultItem constant captures default_price_cents.value once at component definition. If the store's default_price_cents changes after the component mounts, newly added rows will still use the stale initial value.

♻️ Compute default item dynamically

-const _defaultItem: PixelSizeAssignment = { pixel_size_id: 0, price: default_price_cents.value, license_type: "personal" };
+function createDefaultItem(): PixelSizeAssignment {
+	return { pixel_size_id: 0, price: default_price_cents.value, license_type: "personal" };
+}

Then update line 34:

-	`@click`="items.push({ ..._defaultItem })"
+	`@click`="items.push(createDefaultItem())"

resources/js/components/forms/shop-management/PrintSizePricesInput.vue (2)

40-44: ⚡ Quick win

Consolidate Vue imports to eliminate duplication.

The watch function is imported separately on line 74, but it should be imported alongside onMounted and ref on line 40.

♻️ Consolidate imports

-import { onMounted, ref } from "vue";
+import { onMounted, ref, watch } from "vue";
 import InputCurrency from "`@/components/forms/basic/InputCurrency.vue`";
 import ShopManagementService from "`@/services/shop-management-service`";
 import { useShopManagementStore } from "`@/stores/ShopManagement`";
 import { storeToRefs } from "pinia";
 
 // ... later in file
-import { watch } from "vue";
 watch(

Also applies to: 74-74

---

60-60: ⚡ Quick win

Compute default item dynamically to avoid stale pricing.

The _defaultItem constant captures default_price_cents.value once at component definition. If the store's default_price_cents changes after the component mounts, newly added rows will still use the stale initial value.

♻️ Compute default item dynamically

-const _defaultItem: PrintSizeAssignment = { print_size_id: 0, price: default_price_cents.value };
+function createDefaultItem(): PrintSizeAssignment {
+	return { print_size_id: 0, price: default_price_cents.value };
+}

Then update line 31:

-	`@click`="items.push({ ..._defaultItem })"
+	`@click`="items.push(createDefaultItem())"

tests/Unit/Actions/Shop/PurchasableSyncSizesTest.php (1)

196-196: ⚡ Quick win

Prefer strict identity assertions for ID checks.

Use assertSame() instead of assertEquals() for IDs to keep strict-comparison semantics in tests.

As per coding guidelines, PHP code should "Use strict comparison (===) instead of loose comparison (==)".

Also applies to: 203-203

Source: Coding guidelines